feature: Respect the file information for languages from the API CF-1742#164
feature: Respect the file information for languages from the API CF-1742#164
Conversation
machadoit
requested review from
andrzej-janczak,
lventura-codacy and
pedrobpereira
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Trivy should check and report on requirements.txt (done) Pylint should ignore the requirements.txt (not done yet) When the CLI is fixed to generate the correct files for pylint (not having the requirements.txt file), the langauges-config.yaml should be regenerated in order to fix the test
machadoit
force-pushed
the
consider-files-CF-1742
branch
from
be8544c to
3ff97a7
Compare
| name: trivy | ||
| description: Trivy is a comprehensive security scanner for containers and other artifacts. | ||
| default_version: 0.59.1 | ||
| support_specific_files: true |
There was a problem hiding this comment.
I think it would be cool to also have it in API, but for now 👌 of course
There was a problem hiding this comment.
Yeah I guess that is fair, let's aim this for now to have something simple. Also, I think this it not working that well. We might as well just add it on the code or something simpler and later discuss where we want to add it and how. Maybe each tool can clarify what items it consider extra extensions?
andrzej-janczak
left a comment
andrzej-janczak
left a comment
There was a problem hiding this comment.
LGTM
Tested locally both local and remote mode, works ok.
However discover is not working with this:
go run cli-v2.go config discover requirements.txt
Discovering languages and tools for path: requirements.txt
No relevant tools found for the file extensions in the provided path.
But it can be fixed later
This reverts commit 3ff97a7. This was not working properly due timings of configs
machadoit
force-pushed
the
consider-files-CF-1742
branch
from
845cd52 to
c91d49b
Compare
2 participants
Uh oh!
There was an error while loading. Please reload this page.